Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#91 closed defect (fixed)

Installation of 0.4.1 on unregistered system crashes browser upon plugin check.

Reported by: asavage Owned by:
Priority: minor Milestone: 0.4.2
Component: wrapper Version: 0.4.1
Severity: high Keywords:
Cc: asavage, dryeo


Tested on FF 10.0.12ESR
New profile

After installation on a system that does not have these valid files on the PATH:
ecsreg .ini

Open a tab, for URL use "about:plugins"
The browser crashes upon wrapper load. On a slow system, you will briefly see:

"You may not use the Flash plugin with an unregistered copy of eComStation"

On a slow system, you do not have time to read this before FF crashes. I was able to catch & read it using PMView's screen capture function.

a) The browser should probably not crash in this situation;
b) The dialogue could also state that the eCS registration file(s) could not be found, or a note added to flash.txt to that effect.

Steven Levine opines that this may be a javascript defect.

Attachments (1)

exceptq_trap.TRP (42.5 KB) - added by asavage 7 years ago.

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by asavage

Attachment: exceptq_trap.TRP added

comment:1 Changed 7 years ago by asavage

Cc: asavage added

comment:2 Changed 7 years ago by dryeo

Cc: dryeo added

comment:3 Changed 7 years ago by Silvan Scherrer

Milestone: Enhanced0.4.2

comment:4 Changed 6 years ago by Silvan Scherrer

the message is good, but it should not crash the browser.

comment:5 Changed 6 years ago by dmik

The latest version of FF (17.0.5 beta 2) doesn't crash but instead hangs after dismissing the dialog with the OK button. The hang is so bad that I have to reboot. This is also not good. I will quickly look at it.

My guess is that the dialog somehow stops (possibly, JavaScript? related) message processing inside Firefox and this causes strange effects. This dialog should be non-blocking perhaps.

Last edited 6 years ago by dmik (previous) (diff)

comment:6 Changed 6 years ago by dmik

BTW it's a sole a problem of Firefox not expecting that Plugin DLL initialization may last for a long time and fail in the end. It has nothing to do with the plugin itself. I recalled that I had exactly the same crashes when I was working on the plugin and was trying to make it show a dialog box saying that e.g. the user lacks the correct version of NPSWF32.DLL and such. When I discovered this crash I just gave up the idea. But there are still a number of cases where a similar message box may be shown. So we should deal with that.

I will try to do a regular dialog box that won't block the DLL init routine.

comment:7 Changed 6 years ago by Silvan Scherrer

That would be good. As such a hang is really bad.

comment:8 Changed 6 years ago by dmik

Okay, done in r123. I used WinMessageBox2 in non-modal mode and now Firefox doesn't crash as it continues to process its messages normally. Looks not bad to me.

Also, as it doesn't crash any more, in r124 I restored an error message box appearing if NPSWF32.DLL is missing or has some really bad size. Quite useful. Prior to that, the Firefox would silently report that there is no Flash plugin in about:plugins.

Last edited 6 years ago by dmik (previous) (diff)

comment:9 Changed 6 years ago by dmik

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.