Opened 2 years ago

Closed 2 years ago

#38 closed defect (fixed)

Make the plugin not require any registry entries

Reported by: dmik Owned by:
Priority: major Milestone: Beta1
Component: documentation Version:
Severity: Keywords:
Cc:

Description (last modified by dmik)

Now, the flash plugin requires at least the following in the registry in order to function properly:

REGEDIT4

[HINI_USER_PROFILE\Flash10_Plugin]
AdobePluginPath="C:\PROGRAMS\MOZ_PLUG"
PluginWrapperPath="C:\PROGRAMS\MOZ_PLUG"

[HINI_USER_PROFILE\KLIBC]
OdinPath="C:\usr\lib"

This does not seem to be actually necessary, at least not by default. The wrapper (npflos2.dll) gets picked up by Firefox normally, through the plugin loading mechanism (which involves one environment variable, MOZ_PLUGIN_PATH), no explicit location specification is necessary. The wrapper may then simply load npswf32.dll from the same directory where it is located itself (as this is usually the case).

As for OdinPath?, it is not necessary too since by default the wrapper may simply load kernel32.dll from the current LIBPATH (which will be usually the case too). Currently, this may already be overridden with the FLASH10_ODIN environment variable and we may add a similar variable to override the npswf32.dll location if we want.

Change History (6)

comment:1 Changed 2 years ago by dmik

  • Description modified (diff)

comment:2 Changed 2 years ago by dmik

Regarding OdinPath?, here is why it was added: http://svn.netlabs.org/odin32/ticket/11. Not too much relevant any more now since we basically switched to RPM (implying a well defined DLL location) and since Odin works great with BEGINLIBPATH/LIBPATHSTRICT now.

comment:3 Changed 2 years ago by diver

  • Milestone changed from Beta2 to Beta1

comment:4 Changed 2 years ago by dmik

Removed the KLIB/OdinPath requirement in r42:

Locate Odin DLLs in a standard way through [BEGIN]LIBPATH by default.

With this changeset, it's no more necessary to have the KLIB/Odin key
in the user registry. If, for some reason, a different version of Odin needs
to be loaded with the plugin, one may use the standard
BEGINLIBPATH/LIBPATHSTRICT=T trick for it.

Alternatively, the NPFLOS2_ODINDLLPATH environment variable may be
set to override the default DLL search location but this is essentially equivalent
to using the above two standard variables and kept there just for very lazy
people.

comment:5 Changed 2 years ago by dmik

Removed the Flash10_Plugin\AdobePluginPath? requirement in r44:

Deduce Win32 plugin location from wrapper DLL location.

By default, the wrapper DLL will try to load a Win32 DLL named 'npswf32.dll'
from the same directory where the wrapper DLL resides -- this is the most
common case. No registry entry (Flash10_Plugin\AdobePluginPath) is necessary
any longer and support for it is removed.

For the purposes of customization (testing, debugging), the Win32 DLL path may
be overridden with the NPFLOS2_WIN32DLL environment variable containing
the full path to the DLL including the file name.

Note that I couldn't find where the PluginWrapperPath? key is used (also searched in Odin) so I think it can be simply dropped from the installers.

comment:6 Changed 2 years ago by dmik

  • Resolution set to fixed
  • Status changed from new to closed

Nothing to do here any more.

Note: See TracTickets for help on using tickets.